Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbbGBNrH (ORCPT ); Thu, 2 Jul 2015 09:47:07 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:43546 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbGBNq7 (ORCPT ); Thu, 2 Jul 2015 09:46:59 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Thu, 02 Jul 2015 15:44:20 +0200 From: Stefan Agner To: Cory Tusar Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawnguo@kernel.org, kernel@pengutronix.de, han.xu@freescale.com, dwmw2@infradead.org, computersforpeace@gmail.com, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, andrew@lunn.ch Subject: Re: [RFC PATCH 2/7] ARM: dts: vfxxx: Include support for qspi1 functionality. In-Reply-To: <1435782010-9809-4-git-send-email-cory.tusar@pid1solutions.com> References: <1435782010-9809-1-git-send-email-cory.tusar@pid1solutions.com> <1435782010-9809-4-git-send-email-cory.tusar@pid1solutions.com> Message-ID: <0d7c39d4b78fec56adc8a8d66301a3ad@agner.ch> User-Agent: Roundcube Webmail/1.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 47 On 2015-07-01 22:20, Cory Tusar wrote: > This commit extends the existing Vybrid QSPI devicetree implementation > to also describe the qspi1 functional block. > > Signed-off-by: Cory Tusar > --- > arch/arm/boot/dts/vfxxx.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 089a263..a7c370e 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -251,6 +251,19 @@ > status = "disabled"; > }; > > + qspi1: quadspi@400c4000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,vf610-qspi"; > + reg = <0x400c4000 0x1000>, <0x50000000 0x10000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks VF610_CLK_QSPI1_EN>, > + <&clks VF610_CLK_QSPI1>; > + clock-names = "qspi_en", "qspi"; > + status = "disabled"; > + }; > + > iomuxc: iomuxc@40048000 { > compatible = "fsl,vf610-iomuxc"; > reg = <0x40048000 0x1000>; This seem to be at the wrong place under aips0. qspi1 should be under aips1. just before fec0. But other than that, I checked the addresses looks good to me. Hence with that change applied you can include: Reviewed-by: Stefan Agner -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/