Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbbGBNx4 (ORCPT ); Thu, 2 Jul 2015 09:53:56 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:38040 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbbGBNxq (ORCPT ); Thu, 2 Jul 2015 09:53:46 -0400 Message-ID: <55954257.2020102@linaro.org> Date: Thu, 02 Jul 2015 15:53:27 +0200 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paolo Bonzini , eric.auger@st.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, alex.williamson@redhat.com, avi.kivity@gmail.com, mtosatti@redhat.com, feng.wu@intel.com, joro@8bytes.org, b.reynal@virtualopensystems.com CC: linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [RFC 16/17] KVM: eventfd: add irq bypass consumer management References: <1435843047-6327-1-git-send-email-eric.auger@linaro.org> <1435843047-6327-17-git-send-email-eric.auger@linaro.org> <55953FAF.2060401@redhat.com> In-Reply-To: <55953FAF.2060401@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2809 Lines: 95 On 07/02/2015 03:42 PM, Paolo Bonzini wrote: > > > On 02/07/2015 15:17, Eric Auger wrote: >> This patch adds the registration/unregistration of an >> irq_bypass_consumer on irqfd assignment/deassignment. >> >> Signed-off-by: Eric Auger >> --- >> virt/kvm/eventfd.c | 22 +++++++++++++++++++--- >> 1 file changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c >> index f3da161..425a47b 100644 >> --- a/virt/kvm/eventfd.c >> +++ b/virt/kvm/eventfd.c >> @@ -34,6 +34,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #include >> @@ -93,6 +94,7 @@ struct _irqfd { >> struct list_head list; >> poll_table pt; >> struct work_struct shutdown; >> + struct irq_bypass_consumer *cons; >> }; >> >> static struct workqueue_struct *irqfd_cleanup_wq; >> @@ -429,7 +431,21 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args) >> */ >> fdput(f); >> >> - /* irq_bypass_register_consumer(); */ >> + irqfd->cons = kzalloc(sizeof(struct irq_bypass_consumer), >> + GFP_KERNEL); > > Apart from the struct embedding technique I suggested in patch 12, this > looks very reasonable. Thanks! Hi Paolo, thanks for the swift feedback. I will respin shortly with the advised embedding technique. Best Regards Eric > > Paolo > >> + if (!irqfd->cons) { >> + ret = -ENOMEM; >> + goto fail; >> + } >> + irqfd->cons->token = (void *)irqfd->eventfd; >> + irqfd->cons->gsi = irqfd->gsi; >> + irqfd->cons->kvm = kvm; >> + irqfd->cons->add_producer = kvm_arch_add_producer; >> + irqfd->cons->del_producer = kvm_arch_del_producer; >> + irqfd->cons->stop_consumer = kvm_arch_stop_consumer; >> + irqfd->cons->resume_consumer = kvm_arch_resume_consumer; >> + ret = irq_bypass_register_consumer(irqfd->cons); >> + WARN_ON(ret); >> >> return 0; >> >> @@ -530,8 +546,6 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) >> struct _irqfd *irqfd, *tmp; >> struct eventfd_ctx *eventfd; >> >> - /* irq_bypass_unregister_consumer() */ >> - >> eventfd = eventfd_ctx_fdget(args->fd); >> if (IS_ERR(eventfd)) >> return PTR_ERR(eventfd); >> @@ -550,6 +564,8 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) >> irqfd->irq_entry.type = 0; >> write_seqcount_end(&irqfd->irq_entry_sc); >> irqfd_deactivate(irqfd); >> + irq_bypass_unregister_consumer(irqfd->cons); >> + kfree(irqfd->cons); >> } >> } >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/