Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbGBOvP (ORCPT ); Thu, 2 Jul 2015 10:51:15 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:35077 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753117AbbGBOvG (ORCPT ); Thu, 2 Jul 2015 10:51:06 -0400 Message-ID: <55954FC7.3070604@linaro.org> Date: Thu, 02 Jul 2015 16:50:47 +0200 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pavel Fedin , eric.auger@st.com, linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, christoffer.dall@linaro.org, andre.przywara@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org CC: linux-kernel@vger.kernel.org, patches@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi References: <1435592237-17924-1-git-send-email-eric.auger@linaro.org> <1435592237-17924-2-git-send-email-eric.auger@linaro.org> <011f01d0b498$6a17aeb0$3e470c10$@samsung.com> <018f01d0b4a2$d74e29f0$85ea7dd0$@samsung.com> In-Reply-To: <018f01d0b4a2$d74e29f0$85ea7dd0$@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 44 On 07/02/2015 10:41 AM, Pavel Fedin wrote: > Hello! > >> What if we use KVM_MSI_VALID_DEVID flag instead of new KVM_IRQ_ROUTING_EXTENDED_MSI >> definition? I >> believe this would make an API more consistent and introduce less new definitions. > > I have just found one more flaw in your implementation. If you take a look at irqfd_wakeup()... > --- cut --- > /* An event has been signaled, inject an interrupt */ > if (irq.type == KVM_IRQ_ROUTING_MSI) > kvm_set_msi(&irq, kvm, KVM_USERSPACE_IRQ_SOURCE_ID, 1, > false); > else > schedule_work(&irqfd->inject); > --- cut --- > You apparently missed KVM_IRQ_ROUTING_EXTENDED_MSI here, as well as in irqfd_update(). But, if you > accept my API proposal, this becomes irrelevant. Hi Pavel, thanks for spotting this bug. Whatever the user-api API choice I will respin shortly fixing this plus the one reported by Andr?. Thanks for the review. Best Regards Eric > > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/