Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752440AbbGBQEo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jul 2015 12:04:44 -0400
Received: from imap.thunk.org ([74.207.234.97]:37287 "EHLO imap.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752937AbbGBQEh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jul 2015 12:04:37 -0400
Date: Thu, 2 Jul 2015 12:03:41 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Michal Hocko <mhocko@suse.cz>
Cc: Nicholas Krause <xerofoify@gmail.com>, akpm@linux-foundation.org,
        mgorman@suse.de, n-horiguchi@ah.jp.nec.com, sasha.levin@oracle.com,
        Yalin.Wang@sonymobile.com, jmarchan@redhat.com, kirill@shutemov.name,
        rientjes@google.com, vbabka@suse.cz, aneesh.kumar@linux.vnet.ibm.com,
        ebru.akagunduz@gmail.com, hannes@cmpxchg.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm:Make the function zap_huge_pmd bool
Message-ID: <20150702160341.GC9456@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
	Michal Hocko <mhocko@suse.cz>,
	Nicholas Krause <xerofoify@gmail.com>, akpm@linux-foundation.org,
	mgorman@suse.de, n-horiguchi@ah.jp.nec.com, sasha.levin@oracle.com,
	Yalin.Wang@sonymobile.com, jmarchan@redhat.com,
	kirill@shutemov.name, rientjes@google.com, vbabka@suse.cz,
	aneesh.kumar@linux.vnet.ibm.com, ebru.akagunduz@gmail.com,
	hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
References: <1435775277-27381-1-git-send-email-xerofoify@gmail.com>
 <20150702072621.GB12547@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150702072621.GB12547@dhcp22.suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1583
Lines: 36

On Thu, Jul 02, 2015 at 09:26:21AM +0200, Michal Hocko wrote:
> On Wed 01-07-15 14:27:57, Nicholas Krause wrote:
> > This makes the function zap_huge_pmd have a return type of bool
> > now due to this particular function always returning one or zero
> > as its return value.
> 
> How does this help anything? IMO this just generates a pointless churn
> in the code without a good reason.

Hi Michal,

My recommendation is to ignore patches sent by Nick.  In my experience
he doesn't understand code before trying to make mechanical changes,
and very few of his patches add any new value, and at least one that
he tried to send me just 2 weeks or so ago (cherry-picked to try to
"prove" why he had turned over a new leaf, so that I would support the
removal of his e-mail address from being blacklisted on
vger.kernel.org) was buggy, and when I asked him some basic questions
about what the code was doing, it was clear he had no clue how the
seq_file abstraction worked.  This didn't stop him from trying to
patch the code, and if he had tested it, it would have crashed and
burned instantly.

Of course, do whatevery you want, but IMHO it's not really not worth
your time to deal with his patches, and if you reply, most people
won't see his original e-mail since the vger.kernel.org blacklist is
still in effect.

Regards,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/