Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753860AbbGBQ3t (ORCPT ); Thu, 2 Jul 2015 12:29:49 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54344 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181AbbGBQ3m (ORCPT ); Thu, 2 Jul 2015 12:29:42 -0400 Date: Thu, 2 Jul 2015 18:29:19 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Rik van Riel , Oleg Nesterov , Denys Vlasenko , Kees Cook , Brian Gerst , Paul McKenney Subject: Re: [PATCH v4 10/17] x86/entry/64: Really create an error-entry-from-usermode code path Message-ID: <20150702162918.GL4001@pd.tnic> References: <88b8446ce3af6822db02b5f983b8740f8365e9b4.1435602481.git.luto@kernel.org> <20150702102520.GE4001@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 32 On Thu, Jul 02, 2015 at 08:33:05AM -0700, Andy Lutomirski wrote: > "Migrate error and interrupt exit work to C" puts code between those > labels. I could squash the patches together to make it less > mysterious. Nah, it is my mistake of not reviewing the whole thing first and then sending replies. Sorry about that. > > Also, please make all those labels local by prefixing them with .L > > because they appear unnecesasrily in objdump output as global symbols. > > Will do. Yeah, the only maybe partly advantage of having the global labels would be to ease debuggability but one can get to the proper offset even without those labels so... > I'll try to think of a good shorter name. No promises :) :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/