Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753672AbbGBQtT (ORCPT ); Thu, 2 Jul 2015 12:49:19 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:34196 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754089AbbGBQtI (ORCPT ); Thu, 2 Jul 2015 12:49:08 -0400 Message-ID: <55956B7E.9010606@pid1solutions.com> Date: Thu, 02 Jul 2015 12:49:02 -0400 From: Cory Tusar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefan Agner CC: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawnguo@kernel.org, kernel@pengutronix.de, han.xu@freescale.com, dwmw2@infradead.org, computersforpeace@gmail.com, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, andrew@lunn.ch Subject: Re: [RFC PATCH 2/7] ARM: dts: vfxxx: Include support for qspi1 functionality. References: <1435782010-9809-1-git-send-email-cory.tusar@pid1solutions.com> <1435782010-9809-4-git-send-email-cory.tusar@pid1solutions.com> <0d7c39d4b78fec56adc8a8d66301a3ad@agner.ch> In-Reply-To: <0d7c39d4b78fec56adc8a8d66301a3ad@agner.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2388 Lines: 77 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/02/2015 09:44 AM, Stefan Agner wrote: > On 2015-07-01 22:20, Cory Tusar wrote: >> This commit extends the existing Vybrid QSPI devicetree implementation >> to also describe the qspi1 functional block. >> >> Signed-off-by: Cory Tusar >> --- >> arch/arm/boot/dts/vfxxx.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi >> index 089a263..a7c370e 100644 >> --- a/arch/arm/boot/dts/vfxxx.dtsi >> +++ b/arch/arm/boot/dts/vfxxx.dtsi >> @@ -251,6 +251,19 @@ >> status = "disabled"; >> }; >> >> + qspi1: quadspi@400c4000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "fsl,vf610-qspi"; >> + reg = <0x400c4000 0x1000>, <0x50000000 0x10000000>; >> + reg-names = "QuadSPI", "QuadSPI-memory"; >> + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&clks VF610_CLK_QSPI1_EN>, >> + <&clks VF610_CLK_QSPI1>; >> + clock-names = "qspi_en", "qspi"; >> + status = "disabled"; >> + }; >> + >> iomuxc: iomuxc@40048000 { >> compatible = "fsl,vf610-iomuxc"; >> reg = <0x40048000 0x1000>; > > This seem to be at the wrong place under aips0. qspi1 should be under > aips1. just before fec0. But other than that, I checked the addresses > looks good to me. Hence with that change applied you can include: > > Reviewed-by: Stefan Agner Hi Stefan, Thanks for the review. Will update for the next version. You'd think I would've checked that after making the same goof with i2c... :/ - -Cory - -- Cory Tusar Principal PID 1 Solutions, Inc. "There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies, and the other way is to make it so complicated that there are no obvious deficiencies." --Sir Charles Anthony Richard Hoare -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlWVa34ACgkQHT1tsfGwHJ/yCwCfU0jadwpYzOmZ86jDqSvtht+A XvkAoKqfQJQmwVSibjxRDe57DcCWYlXd =+QPB -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/