Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754266AbbGBREU (ORCPT ); Thu, 2 Jul 2015 13:04:20 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35868 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754145AbbGBREL (ORCPT ); Thu, 2 Jul 2015 13:04:11 -0400 Date: Thu, 2 Jul 2015 13:04:07 -0400 From: Tejun Heo To: Jason Gunthorpe Cc: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, Vivien Didelot , Guenter Roeck , NeilBrown Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Message-ID: <20150702170407.GD30677@mtj.duckdns.org> References: <1434993894-5911-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1434993894-5911-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150622173039.GA3710@mtj.duckdns.org> <20150622175253.GA28080@obsidianresearch.com> <20150622180154.GC3710@mtj.duckdns.org> <20150623161932.GA20922@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150623161932.GA20922@obsidianresearch.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 26 Hello, Jason. On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote: > The concept was to move the sysfs files to the natural location on the > core's struct tpm.struct device and leave a symlink behind on the > platform_device for compat. I see. The only problem I see is that this might get abused. Can you clearly mark the function that it's not intended to be used in anything new, e.g. by renaming it to sth like __compat_only_sysfs_link_entry_to_kobj(). > We could also just move the sysfs file and ignore the compat symlink, > but it is not clear to me if that is an OK UAPI break for sysfs? We shouldn't if it has actual chance of disturbing userland. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/