Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbbGBRv3 (ORCPT ); Thu, 2 Jul 2015 13:51:29 -0400 Received: from [192.147.44.131] ([192.147.44.131]:51242 "EHLO us-mx1.synaptics.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754141AbbGBRvL (ORCPT ); Thu, 2 Jul 2015 13:51:11 -0400 X-PGP-Universal: processed; by securemail.synaptics.com on Thu, 02 Jul 2015 11:37:27 -0700 Message-ID: <559579FA.2080601@synaptics.com> Date: Thu, 2 Jul 2015 10:50:50 -0700 From: Andrew Duggan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Benjamin Tissoires , Dmitry Torokhov , Christopher Heiny , Allie Xiong CC: Stephen Chandler Paul , , , , Vincent Huang Subject: Re: [PATCH 07/11] Input: synaptics-rmi4 - f11: fix bitmap irq check References: <1435087050-11444-1-git-send-email-benjamin.tissoires@redhat.com> <1435087050-11444-8-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1435087050-11444-8-git-send-email-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.145] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 37 On 06/23/2015 12:17 PM, Benjamin Tissoires wrote: > num_irq_regs is the count of registers of 1 bytes that we use to check > the irqs. bitmap_and() expects the number of bits. > > Signed-off-by: Benjamin Tissoires > --- Reviewed-by: Andrew Duggan > drivers/input/rmi4/rmi_f11.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index 99d6181..c3b757b 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -726,12 +726,12 @@ static void rmi_f11_finger_handler(struct f11_data *f11, > } > > abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask, > - num_irq_regs); > + num_irq_regs * 8); > if (abs_bits) > rmi_f11_abs_pos_report(f11, sensor, finger_state, i); > > rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask, > - num_irq_regs); > + num_irq_regs * 8); > if (rel_bits) > rmi_f11_rel_pos_report(sensor, i); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/