Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbbGBSLA (ORCPT ); Thu, 2 Jul 2015 14:11:00 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:8215 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbbGBSKw (ORCPT ); Thu, 2 Jul 2015 14:10:52 -0400 Date: Thu, 2 Jul 2015 11:10:36 -0700 From: Bjorn Andersson To: Mark Brown CC: Ulf Hansson , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [PATCH] mmc: core: Set load on vmmc and vqmmc Message-ID: <20150702181036.GF9633@sonymobile.com> References: <1435725525-4367-1-git-send-email-bjorn.andersson@sonymobile.com> <20150701105925.GT11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150701105925.GT11162@sirena.org.uk> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1014 Lines: 27 On Wed 01 Jul 03:59 PDT 2015, Mark Brown wrote: > On Tue, Jun 30, 2015 at 09:38:45PM -0700, Bjorn Andersson wrote: > > > +- vmmc-load: requested load for the vmmc regulator, in mA > > +- vqmmc-load: requested load for the vqmmc regulator, in mA > > Isn't this something that should have default values from the spec? The > binding also ought to say what a "requested load" is. It sounds reasonable that these values should simply come from the card specification; I don't know if there's any sane way for us to list them though (other than just stating them in dt). I'll have to do some more investigation on the subject... And I get your point that it's not "requested load", it's the power requirements of the card...so it should be rephrased. Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/