Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbbGBSiH (ORCPT ); Thu, 2 Jul 2015 14:38:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45951 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbbGBSiA (ORCPT ); Thu, 2 Jul 2015 14:38:00 -0400 Message-ID: <55958505.3020508@codeaurora.org> Date: Thu, 02 Jul 2015 11:37:57 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bjorn Andersson CC: Kumar Gala , Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-soc@vger.kernel.org" Subject: Re: [PATCH] firmware: qcom: scm: Peripheral Authentication Service References: <1435693579-16109-1-git-send-email-bjorn.andersson@sonymobile.com> <559564AC.6030100@codeaurora.org> <20150702173725.GE9633@sonymobile.com> In-Reply-To: <20150702173725.GE9633@sonymobile.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 31 On 07/02/2015 10:37 AM, Bjorn Andersson wrote: > On Thu 02 Jul 09:19 PDT 2015, Stephen Boyd wrote: > >> On 06/30/2015 12:46 PM, Bjorn Andersson wrote: >>> + >>> +int __qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size) >>> +{ >>> + dma_addr_t mdata_phys; >>> + void *mdata_buf; >>> + u32 scm_ret; >>> + int ret; >>> + struct pas_init_image_req { >>> + u32 proc; >>> + u32 image_addr; >> Please mark these as __le32 and do the appropriate conversions to little >> endian. > Just out of curiosity, are there any big endian systems out there that > will run this code? The option is available to turn on if someone wants to. I'm not aware of anyone that's doing it besides me though. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/