Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753952AbbGBTXE (ORCPT ); Thu, 2 Jul 2015 15:23:04 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:25432 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754104AbbGBTW4 (ORCPT ); Thu, 2 Jul 2015 15:22:56 -0400 Message-ID: <55958F73.5070208@fb.com> Date: Thu, 2 Jul 2015 13:22:27 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Calvin Owens , Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan CC: , , , , Christoph Hellwig Subject: Re: [PATCH 0/6] Fixes for memory corruption in mpt2sas References: <20150506184852.GA1007288@mail.thefacebook.com> <1431661322-3097935-1-git-send-email-calvinowens@fb.com> In-Reply-To: <1431661322-3097935-1-git-send-email-calvinowens@fb.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-07-02_13:2015-07-02,2015-07-02,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 27 On 05/14/2015 09:41 PM, Calvin Owens wrote: > Hello all, > > This patchset attempts to address problems we've been having with > panics due to memory corruption from the mpt2sas driver. > > I will provide a similar set of fixes for mpt3sas, since we see > similar issues there as well. "Porting" this to mpt3sas will be > trivial since the part of the driver I'm touching is nearly identical > between the two, so I thought it would be simpler to review a patch > against mpt2sas alone at first. > > I've tested this for a few days on a big storage box that seemed to be > very susceptible to the panics, and so far it seems to have eliminated > them. Guys, can someone outside of FB please review this? We're hitting random memory corruptions without these fixes. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/