Message-ID: <55959BC9.8000103@sandisk.com>
Date: Thu, 2 Jul 2015 13:15:05 -0700
From: Bart Van Assche <bart.vanassche@sandisk.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Calvin Owens <calvinowens@fb.com>,
        Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
        Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
        Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
        Abhijit Mahajan <abhijit.mahajan@avagotech.com>
CC: <MPT-FusionLinux.pdl@avagotech.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
        Jens Axboe <axboe@kernel.dk>
Subject: Re: [RESEND][PATCH 0/6] Fixes for memory corruption in mpt2sas
References: <1431661322-3097935-1-git-send-email-calvinowens@fb.com>
 <1433821856-2815280-1-git-send-email-calvinowens@fb.com>
In-Reply-To: <1433821856-2815280-1-git-send-email-calvinowens@fb.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2015 20:15:05.9139
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1374
X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1664;2:0j4U6ZpwjCKnnKgoYOmySvpAQM6IUwkjIGzJXXqJ0AUrdVB5d4wHOQ15uIceFqIh;2:QbC/l0kigi+jCNAy6i+1leUdc6Xs3u7k3Z6byIV/X1M9cm9PA2oh5w7QO7CBZhmQyUvjqK3S1B5BoJpC1OpYMxR5ZVYXBAFTQUdUNo6IA0RS+zGGABg2ogYQ1FN8LxGe9xzx89RLb94alT5hpM5RJoBk7WEVzMADufeJX6rtBrIa1p36pf77g7vBi1Rz29smuYL9g4VUhl04uxXQhQNF9TxR5UFTSb2Ne28lRhU7ofDgIQd+meTwGpBsX+Y7ADUQ;9:kzSHi568dThSIURt3lZZX9P5u5ydKCRCJWLUWcOUl6kxB2eCnkMCJaTuHqGU5tLyRkrp9xyUnudcmjutr1q4rHRxPhflJR1d7+2lf0JFZQMiYi7/OgwSNq06FCOozZfqdfJOFLz1MhFEMSDoT6oM+A==
X-OriginatorOrg: sandisk.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1107
Lines: 24

On 06/08/2015 08:50 PM, Calvin Owens wrote:
> This patchset attempts to address problems we've been having with
> panics due to memory corruption from the mpt2sas driver.
>
> I will provide a similar set of fixes for mpt3sas, since we see
> similar issues there as well. "Porting" this to mpt3sas will be
> trivial since the part of the driver I'm touching is nearly identical
> between the two, so I thought it would be simpler to review a patch
> against mpt2sas alone at first.
>
> I've tested this on a handful of large storage boxes over the past few
> weeks, so far it seems to have completely eliminated the memory
> corruption panics.

If you have to repost this series please convert 
BUG_ON(!spin_is_locked(&ioc->sas_device_lock)); into 
lockdep_is_held(...). Otherwise, for the whole series:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/