Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753672AbbGCCCs (ORCPT ); Thu, 2 Jul 2015 22:02:48 -0400 Received: from mga02.intel.com ([134.134.136.20]:54388 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbbGCCCm (ORCPT ); Thu, 2 Jul 2015 22:02:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,396,1432623600"; d="scan'208";a="599324766" Subject: Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online To: Thomas Gleixner , "Zhang, Yanmin" References: <1435811074-30062-1-git-send-email-jin.xiao@intel.com> <20150702065215.GD16233@suse.de> <5594E1F2.5060602@intel.com> <5595025C.5050306@linux.intel.com> Cc: Joerg Roedel , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, boris.ostrovsky@oracle.com, dave.hansen@linux.intel.com, rientjes@google.com, imammedo@redhat.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, xinhuix.pan@intel.com From: "Xiao, Jin" Message-ID: <5595ED3B.3000708@intel.com> Date: Fri, 3 Jul 2015 10:02:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 28 Hi tglx, On 7/2/2015 8:50 PM, Thomas Gleixner wrote: > > The whole vector stuff is racy versus cpu hotplug and Jins patch > merily addresses a small part of it and by doing that it breaks stuff > as well. > > With that patch we move the vector setup after marking the cpu online, > which is wrong because the vector array on that cpu is not up to date > until we call __setup_vector_irq(). Proper patch below. > > We still have an issue in the cpu_disable() patch, but I haven't yet > wrapped my head around it completely. > > Thanks, > > tglx > Your patch is better. Thanks. Jin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/