Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753897AbbGCHDC (ORCPT ); Fri, 3 Jul 2015 03:03:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32954 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbbGCHCy (ORCPT ); Fri, 3 Jul 2015 03:02:54 -0400 Subject: Re: [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control To: Eric Auger , "Wu, Feng" , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "christoffer.dall@linaro.org" , "marc.zyngier@arm.com" , "alex.williamson@redhat.com" , "avi.kivity@gmail.com" , "mtosatti@redhat.com" , "joro@8bytes.org" , "b.reynal@virtualopensystems.com" References: <1435843047-6327-1-git-send-email-eric.auger@linaro.org> <1435843047-6327-13-git-send-email-eric.auger@linaro.org> <55953F5F.9090203@redhat.com> <559631C0.4050806@linaro.org> Cc: "linux-kernel@vger.kernel.org" , "patches@linaro.org" From: Paolo Bonzini Message-ID: <55963394.8010401@redhat.com> Date: Fri, 3 Jul 2015 09:02:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <559631C0.4050806@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 22 On 03/07/2015 08:54, Eric Auger wrote: >> > Oh... we can get gsi from irq_bypass_consumer -> _irqfd -> gsi, so it >> > is not needed in irq_bypass_consumer. Got it! :) > The issue I have is that struct _irqfd is local to eventfd.c so it > cannot be used in archi specific code. Is it acceptable to move it to > kvm_host.h, naming it something like kvm_kernel_irqfd (as done for > kvm_kernel_irq_routing_entry)? Would also need to move _irqfd_resampler > there (kvm_kernel_irqfd_resampler). Yes, that's okay. Can you put it in a new header file kvm_irqfd.h though? Paolo > irqfd user struct cannot be used in a standalone manner since we miss > the kvm handle. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/