Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754384AbbGCH3G (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jul 2015 03:29:06 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:49790 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754323AbbGCH26 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jul 2015 03:28:58 -0400
Message-ID: <559639AC.80602@huawei.com>
Date: Fri, 3 Jul 2015 15:28:44 +0800
From: Joseph Qi <joseph.qi@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Gang He <ghe@suse.com>
CC: <mfasheh@suse.com>, <rgoldwyn@suse.de>, <linux-kernel@vger.kernel.org>,
        <ocfs2-devel@oss.oracle.com>
Subject: Re: [Ocfs2-devel] [PATCH 0/4] ocfs2: add online file check feature
References: <1435123461-3525-1-git-send-email-ghe@suse.com>
In-Reply-To: <1435123461-3525-1-git-send-email-ghe@suse.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.24.125]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.559639B5.0194,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: a19c5d346d0628d17a927c928e23fa99
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2314
Lines: 55

Hi Gang,
Thank you and Goldwyn for posting this feature as well as its framework.
This patch set tries to fix inode related errors such as block no, valid
flag, generation, metaecc, etc. I think it may fit some cases but not all.
For example, valid flag not set readonly may be caused by an inode with
two entries, so I think it is not right to just reset it.
Moreover, in our environment, most readonly cases we have encountered are
related gd and entent tree/block. So do you have any consideration about
these cases?
For more details about gd and entent tree/block readonly cases, please
refer the previous mails:
https://oss.oracle.com/pipermail/ocfs2-devel/2015-April/010768.html
https://oss.oracle.com/pipermail/ocfs2-devel/2015-June/010873.html

Thanks,
Joseph

On 2015/6/24 13:24, Gang He wrote:
> When there are errors in the ocfs2 filesystem,
> they are usually accompanied by the inode number which caused the error.
> This inode number would be the input to fixing the file.
> One of these options could be considered:
> A file in the sys filesytem which would accept inode numbers.
> This could be used to communication back what has to be fixed or is fixed.
> You could write:
> $# echo "CHECK <inode>" > /sys/fs/ocfs2/devname/filecheck
> or
> $# echo "FIX <inode>" > /sys/fs/ocfs2/devname/filecheck
> 
> Gang He (4):
>   ocfs2: export ocfs2_kset for online file check
>   ocfs2: sysfile interfaces for online file check
>   ocfs2: create/remove sysfile for online file check
>   ocfs2: check/fix inode block for online file check
> 
>  fs/ocfs2/Makefile      |   3 +-
>  fs/ocfs2/filecheck.c   | 569 +++++++++++++++++++++++++++++++++++++++++++++++++
>  fs/ocfs2/filecheck.h   |  48 +++++
>  fs/ocfs2/inode.c       | 196 ++++++++++++++++-
>  fs/ocfs2/inode.h       |   3 +
>  fs/ocfs2/ocfs2_trace.h |   2 +
>  fs/ocfs2/stackglue.c   |   3 +-
>  fs/ocfs2/stackglue.h   |   2 +
>  fs/ocfs2/super.c       |   5 +
>  9 files changed, 823 insertions(+), 8 deletions(-)
>  create mode 100644 fs/ocfs2/filecheck.c
>  create mode 100644 fs/ocfs2/filecheck.h
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/