Date: Fri, 3 Jul 2015 09:42:08 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "Brown, Len" <len.brown@intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Prarit Bhargava <prarit@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
        "Chandramouli, Dasaratharaman" 
	<dasaratharaman.chandramouli@intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr
Message-ID: <20150703074208.GA21024@gmail.com>
References: <1435341131-3279-1-git-send-email-prarit@redhat.com>
 <20150627083354.GA12834@gmail.com>
 <20150627083921.GA13074@gmail.com>
 <CALCETrXpiMWwiAfbxcKTDYCewrwq-UTwLV+xXTxdOkd+B3G-OQ@mail.gmail.com>
 <1A7043D5F58CCB44A599DFD55ED4C948468A477B@fmsmsx115.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1A7043D5F58CCB44A599DFD55ED4C948468A477B@fmsmsx115.amr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 28


* Brown, Len <len.brown@intel.com> wrote:

> > This driver only knows how to handle counters, though.  I'm not sure
> > whether all of the MSRs that turbostat needs are counters.
> 
> turbostat --debug
> dumps a lot of configuration MSRs that are not counters.
>
> "--debug" is not an obscure option, it is the only way that the turbostat is 
> used by advanced users, since it shows not just how fast a system is running, 
> but explains why.

I see no problems there: the main property for perf is read-only access - so it 
will work fine with non-counting MSRs as well.

Really, for system-wide statistics perf is the way to go, it has rich kernel side 
and user side support. We already kind of expose MSRs via the RAPL energy PMU 
bits. All we need is to extend it to an enumerated list of MSRs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/