Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754677AbbGCJK5 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jul 2015 05:10:57 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:37455 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754693AbbGCJKs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jul 2015 05:10:48 -0400
From: =?UTF-8?Q?Iago_L=c3=b3pez_Galeiras?= <iago@endocode.com>
Subject: Re: config PROC_CHILDREN
To: Jean Delvare <jdelvare@suse.de>
References: <20150703093918.75b98eb7@endymion.delvare>
Cc: LKML <linux-kernel@vger.kernel.org>, Djalal Harouni <djalal@endocode.com>,
        Alban Crequy <alban@endocode.com>
Message-ID: <55965195.6010602@endocode.com>
Date: Fri, 3 Jul 2015 11:10:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <20150703093918.75b98eb7@endymion.delvare>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1337
Lines: 44

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps
that's not clear for the user because as you say the Kconfig help text is missing.

I suggest adding something like:

    Provides a fast way to retrieve first level children pids of a task. See
    <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Thanks.

[1]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt

On 07/03/2015 09:39 AM, Jean Delvare wrote:
> Hi Iago,
> 
> You just introduced a Linux kernel configuration option named
> PROC_CHILDREN. It is user-visible but has no help. This is bad.
> 
> As this option appears to be selected automatically as needed, I'm not
> sure why you made it visible?
> 
> Please either hide the option, or add a help text to let the user make
> a sane decision.
> 
> Thanks,
> 

-- 

Iago L?pez Galeiras
Software developer @ Endocode AG
iago@endocode.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/