Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbbGCJSx (ORCPT ); Fri, 3 Jul 2015 05:18:53 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58959 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754786AbbGCJSe (ORCPT ); Fri, 3 Jul 2015 05:18:34 -0400 Date: Fri, 3 Jul 2015 11:18:31 +0200 From: Antoine Tenart To: Thomas Hebb Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com, antoine.tenart@free-electrons.com, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY Message-ID: <20150703091831.GB5634@kwain> References: <5594C65E.1030802@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5594C65E.1030802@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2279 Lines: 71 Thomas, On Thu, Jul 02, 2015 at 01:04:30AM -0400, Thomas Hebb wrote: > We're not in a SATA PHY driver, so the of_match table shouldn't have > "sata" in its name. There is already a patch fixing this (which was sent last week): https://lkml.org/lkml/2015/6/24/103 You can drop this one from the series. Antoine > > Signed-off-by: Thomas Hebb > Suggested-by: Sebastian Hesselbarth > --- > drivers/phy/phy-berlin-usb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c > index 335e06d..7143cd3 100644 > --- a/drivers/phy/phy-berlin-usb.c > +++ b/drivers/phy/phy-berlin-usb.c > @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = { > .owner = THIS_MODULE, > }; > > -static const struct of_device_id phy_berlin_sata_of_match[] = { > +static const struct of_device_id phy_berlin_usb_of_match[] = { > { > .compatible = "marvell,berlin2-usb-phy", > .data = &phy_berlin_pll_dividers[0], > @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = { > }, > { }, > }; > -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match); > +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match); > > static int phy_berlin_usb_probe(struct platform_device *pdev) > { > const struct of_device_id *match = > - of_match_device(phy_berlin_sata_of_match, &pdev->dev); > + of_match_device(phy_berlin_usb_of_match, &pdev->dev); > struct phy_berlin_usb_priv *priv; > struct resource *res; > struct phy *phy; > @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = { > .driver = { > .name = "phy-berlin-usb", > .owner = THIS_MODULE, > - .of_match_table = phy_berlin_sata_of_match, > + .of_match_table = phy_berlin_usb_of_match, > }, > }; > module_platform_driver(phy_berlin_usb_driver); > -- > 2.4.4 > -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/