Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754796AbbGCMO1 (ORCPT ); Fri, 3 Jul 2015 08:14:27 -0400 Received: from foss.arm.com ([217.140.101.70]:53121 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754870AbbGCMOV (ORCPT ); Fri, 3 Jul 2015 08:14:21 -0400 Message-ID: <55967C97.5010502@arm.com> Date: Fri, 03 Jul 2015 13:14:15 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Eric Auger , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "christoffer.dall@linaro.org" , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "avi.kivity@gmail.com" , "mtosatti@redhat.com" , "feng.wu@intel.com" , "joro@8bytes.org" , "b.reynal@virtualopensystems.com" CC: "linux-kernel@vger.kernel.org" , "patches@linaro.org" Subject: Re: [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt,resume]_guest References: <1435843047-6327-1-git-send-email-eric.auger@linaro.org> <1435843047-6327-9-git-send-email-eric.auger@linaro.org> <55967848.5050204@linaro.org> In-Reply-To: <55967848.5050204@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 41 On 03/07/15 12:55, Eric Auger wrote: > Christoffer, Marc, > On 07/02/2015 03:17 PM, Eric Auger wrote: >> On halt, the guest is forced to exit and prevented from being >> re-entered. This is synchronous. >> >> Those two operations will be needed for IRQ forwarding setting. >> >> Signed-off-by: Eric Auger > would you agree to handle this ARM functionality separately from the > forwarding series? > > This includes 2 patch files, that one + > https://lkml.org/lkml/2015/7/2/288. This functionality is needed for > forwarding control since when changing the forwarding state we need to > "freeze" the state of the physical/virtual IRQ to undertake proper > actions. Stopping the guest makes sure it won't deactivate the virtual > IRQ while we are doing state change actions. > > The forwarding series is quite heterogeneous (VFIO platform driver, > vgic, irq bypass manager) and I think it would simplify the review process. > > Please let me know if you agree. If yes, I will post a separate series. I don't mind, I trust you to do what's best for these series to be easily reviewed (if that is at all possible). The only thing is that this patch implements a feature that will otherwise be unused, so annotating the functions with __maybe_unused would avoid warnings. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/