Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbbGCMse (ORCPT ); Fri, 3 Jul 2015 08:48:34 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33113 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755311AbbGCMsZ (ORCPT ); Fri, 3 Jul 2015 08:48:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1435827662.2423.4.camel@tiscali.nl> <55952723.80801@fau.de> <1435839005.2423.28.camel@tiscali.nl> <55963AD7.3040905@fau.de> <1435913987.2423.38.camel@tiscali.nl> <559655E3.6010400@fau.de> <5596731F.20309@fau.de> Date: Fri, 3 Jul 2015 14:48:25 +0200 Message-ID: Subject: Re: Kconfig: '+config' valid syntax? From: Ulf Magnusson To: Andreas Ruprecht Cc: Paul Bolle , Valentin Rothberg , rafael.j.wysocki@intel.com, "open list:KCONFIG" , Kernel Mailing List , hengelein Stefan , linux@dominikbrodowski.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2571 Lines: 70 On Fri, Jul 3, 2015 at 2:39 PM, Ulf Magnusson wrote: > On Fri, Jul 3, 2015 at 1:40 PM, Ulf Magnusson wrote: >> On Fri, Jul 3, 2015 at 1:33 PM, Andreas Ruprecht >> wrote: >>> On 07/03/2015 12:46, Ulf Magnusson wrote: >>>> >>>> Except for scattered accidents like in the original message, which are >>>> hopefully pretty rare and easy to fix, the only documented thing that depends >>>> on that lexer sloppiness is the ---help--- "token". >>>> >>>> I'd just add "---help---" as another T_HELP alias (or get rid of it altogether, >>>> but that's probably more work than it's worth). Tightening things up should be >>>> safe after that. >>>> >>>> /Ulf >>>> >>> >>> So we might want to do something like the attached patch, right? >>> >>> Unfortunately, when I generate the zconf.{hash,lex,tab}.c files on my >>> machine, they have some notable differences to the _shipped versions: >>> >>> ruprecht@box:linux-next$ diff -u zconf.tab.c zconf.tab.c_shipped >>> - return yyresult; >>> + /* Make sure YYID is used. */ >>> + return YYID (yyresult); >>> >>> and I can't find any Documentation on how to properly rebuild the >>> _shipped files... Does anybody have a hint on that? >>> >>> Regards, >>> >>> Andreas >> >> Yup, something like that. Been too long, so I don't remember either, >> though I don't remember having to do anything special. >> >> I'm heading off to bed soon, so probably shouldn't be thinking. Could >> take a look tomorrow if there's still a problem. :) >> >> /Ulf > > Or add '---help---' to zconf.gperf I guess, to avoid special-casing it. Would > need to add '-' to the > > n [A-Za-z0-9_] > > definition in zconf.l in that case too. > > That should be safe provided the gperf part works out, since zconf.y should > verify that the T_WORD has the expected form. (As a side note, the first token > on a line is always a keyword, except for within help texts, which are handled > specially.) ...or that it's not a T_WORD rather, but a command. :P > > I guess that might change the meaning of lines like "foo-bar" if '-' is > introduced as an operator, but that seems kinda academic as 'foo' would > probably still be a keyword. It's already broken due to the regex > ({n}|[-/.])+ having '-' in it too. > > /Ulf /Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/