Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbbGCNAc (ORCPT ); Fri, 3 Jul 2015 09:00:32 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:52868 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755015AbbGCNAZ (ORCPT ); Fri, 3 Jul 2015 09:00:25 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 03 Jul 2015 14:57:45 +0200 From: Stefan Agner To: Sanchayan Maity Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawn.guo@linaro.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/4] ARM: dts: vfxxx: Add io-channel-cells property for ADC node In-Reply-To: <916569b56d60d41f9cd12c5244be3778857a971b.1435646447.git.maitysanchayan@gmail.com> References: <916569b56d60d41f9cd12c5244be3778857a971b.1435646447.git.maitysanchayan@gmail.com> Message-ID: <101a8c84fbe2063f6cf56737a5f9417f@agner.ch> User-Agent: Roundcube Webmail/1.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 47 On 2015-06-30 08:54, Sanchayan Maity wrote: > This commit adds io-channel-cells property to the ADC node. This > property is required in order for an IIO consumer driver to work. > Especially required for Colibri VF50, as the touchscreen driver > uses ADC channels with the ADC driver based on IIO framework. > > Signed-off-by: Sanchayan Maity > --- > arch/arm/boot/dts/vfxxx.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 2c20f3f..f7d8fb6 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -227,6 +227,7 @@ > clocks = <&clks VF610_CLK_ADC0>; > clock-names = "adc"; > status = "disabled"; > + #io-channel-cells = <1>; > }; > > tcon0: tcon@4003d000 { > @@ -461,6 +462,7 @@ > clocks = <&clks VF610_CLK_ADC1>; > clock-names = "adc"; > status = "disabled"; > + #io-channel-cells = <1>; > }; > > esdhc1: esdhc@400b2000 { Minor nitpick: can you put the new property one line up? That way it would be sorted alphabetically and status is conveniently still at the end. Otherwise: Acked-by: Stefan Agner -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/