Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755381AbbGCOqY (ORCPT ); Fri, 3 Jul 2015 10:46:24 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38781 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964879AbbGCOqP convert rfc822-to-8bit (ORCPT ); Fri, 3 Jul 2015 10:46:15 -0400 References: <1435699387-32591-1-git-send-email-timur@codeaurora.org> <1435699387-32591-2-git-send-email-timur@codeaurora.org> <55947DCD.1020605@codeaurora.org> In-Reply-To: <55947DCD.1020605@codeaurora.org> Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii Message-Id: <42D8621F-E36D-4F4F-9143-3F7773EC834E@codeaurora.org> Content-Transfer-Encoding: 8BIT Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shanker Donthineni , awallis@codeaurora.org, abhimany@codeaurora.org, will.deacon@arm.com, Vipul Gandhi From: Timur Tabi Subject: Re: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Date: Fri, 3 Jul 2015 10:46:11 -0400 To: Stephen Boyd X-Mailer: Apple Mail (2.1085) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 29 On Jul 1, 2015, at 7:54 PM, Stephen Boyd wrote: >> >> + /* Returns -1 if error */ >> + ret = hvc_instantiate(0, 0, &hvc_dcc_get_put_ops); >> + >> + return ret < 0 ? -ENODEV : 0; > > Why not just return the value that hvc_instantiate returns? And maybe we > should change those -1 in hvc_instantiate into -EPERM? Well, I didn't want to change common HVC code. I would have to change all the other drivers that call hvc_instatiate as well. I agree that returning -1 is bad, but fixing that is something that should be done in another patch. >> >> - hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128); >> - return 0; >> + p = hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128); >> + >> + return IS_ERR(p) ? PTR_ERR(p) : 0; > > return PTR_ERR_OR_ZERO()? Yes, thanks. I'll change it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/