Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964903AbbGCPjS (ORCPT ); Fri, 3 Jul 2015 11:39:18 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43846 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964826AbbGCPjA (ORCPT ); Fri, 3 Jul 2015 11:39:00 -0400 Date: Fri, 3 Jul 2015 08:38:59 -0700 From: Christoph Hellwig To: Calvin Owens Cc: Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/6] Add refcount to fw_event_work struct Message-ID: <20150703153859.GC4472@infradead.org> References: <1431661322-3097935-1-git-send-email-calvinowens@fb.com> <1433821856-2815280-1-git-send-email-calvinowens@fb.com> <1433821856-2815280-5-git-send-email-calvinowens@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433821856-2815280-5-git-send-email-calvinowens@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 12 On Mon, Jun 08, 2015 at 08:50:54PM -0700, Calvin Owens wrote: > The fw_event_work struct is concurrently referenced at shutdown, so > add a refcount to protect it. Same comment here - a refcount that isn't used isn't useful, please fold into the next patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/