Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755833AbbGCQJU (ORCPT ); Fri, 3 Jul 2015 12:09:20 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33905 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755475AbbGCQJN (ORCPT ); Fri, 3 Jul 2015 12:09:13 -0400 MIME-Version: 1.0 In-Reply-To: <1435174907-432-1-git-send-email-xiyou.wangcong@gmail.com> References: <1435174907-432-1-git-send-email-xiyou.wangcong@gmail.com> Date: Fri, 3 Jul 2015 09:09:12 -0700 Message-ID: Subject: Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() From: Cong Wang To: LKML Cc: Cong Wang , Ingo Molnar , Peter Zijlstra , Cong Wang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 22 On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang wrote: > According to the comments, we need to test if this is > the first throttled task, however, list_empty() tests on > the entry cfs_rq->throttled_list, not the head, this is wrong. > > This is a bug because we don't re-init the list entry after > removing it from the list, so list_empty() could return false > even if the list is really empty. > > Cc: Ingo Molnar > Cc: Peter Zijlstra > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang ping. What's the status of this patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/