Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbbGCQKz (ORCPT ); Fri, 3 Jul 2015 12:10:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:33293 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755705AbbGCQKo (ORCPT ); Fri, 3 Jul 2015 12:10:44 -0400 Date: Fri, 3 Jul 2015 18:10:37 +0200 From: Peter Zijlstra To: Cong Wang Cc: LKML , Ingo Molnar , Cong Wang Subject: Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() Message-ID: <20150703161037.GM25159@twins.programming.kicks-ass.net> References: <1435174907-432-1-git-send-email-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 25 On Fri, Jul 03, 2015 at 09:09:12AM -0700, Cong Wang wrote: > On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang wrote: > > According to the comments, we need to test if this is > > the first throttled task, however, list_empty() tests on > > the entry cfs_rq->throttled_list, not the head, this is wrong. > > > > This is a bug because we don't re-init the list entry after > > removing it from the list, so list_empty() could return false > > even if the list is really empty. > > > > Cc: Ingo Molnar > > Cc: Peter Zijlstra > > Signed-off-by: Cong Wang > > Signed-off-by: Cong Wang > > ping. > > What's the status of this patch? Queued, will likely hit tip after the merge window etc has settled. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/