Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755420AbbGCRHR (ORCPT ); Fri, 3 Jul 2015 13:07:17 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:36394 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755049AbbGCRHN (ORCPT ); Fri, 3 Jul 2015 13:07:13 -0400 Date: Fri, 3 Jul 2015 13:07:10 -0400 From: Tejun Heo To: Jan Kara Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru Subject: Re: [PATCH 30/51] writeback: implement and use inode_congested() Message-ID: <20150703170710.GF5273@mtj.duckdns.org> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-31-git-send-email-tj@kernel.org> <20150630152105.GP7252@quack.suse.cz> <20150702014634.GF26440@mtj.duckdns.org> <20150703121721.GJ23329@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150703121721.GJ23329@quack.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 26 On Fri, Jul 03, 2015 at 02:17:21PM +0200, Jan Kara wrote: > On Wed 01-07-15 21:46:34, Tejun Heo wrote: > > Hello, > > > > On Tue, Jun 30, 2015 at 05:21:05PM +0200, Jan Kara wrote: > > > Hum, is there any point in supporting NULL inode with inode_congested()? > > > That would look more like a programming bug than anything... Otherwise the > > > patch looks good to me so you can add: > > > > Those are inherited from the existing usages and all for swapper > > space. I think we should have a dummy inode instead of scattering > > NULL mapping->host test all over the place but that's for another day. > > Ah, OK. A comment about this would be nice. Will add. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/