From: KY Srinivasan <kys@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
        Maninder Singh <maninder1.s@samsung.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pankaj.m@samsung.com" <pankaj.m@samsung.com>
Subject: RE: [PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation of
 correct pointer
Thread-Topic: [PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation
 of correct pointer
Thread-Index: AQHQtVObOACICqI41ESGVJ3FSac1ap3JZKcEgACpXjA=
Date: Fri, 3 Jul 2015 18:17:02 +0000
Message-ID: <BY2PR0301MB16548F6E61B8B3F55CB4AEF3A0960@BY2PR0301MB1654.namprd03.prod.outlook.com>
References: <1435902333-31308-1-git-send-email-maninder1.s@samsung.com>
 <876161br1r.fsf@vitty.brq.redhat.com>
In-Reply-To: <876161br1r.fsf@vitty.brq.redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2015 18:17:02.2002
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0774
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1949
Lines: 62


> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Friday, July 3, 2015 1:10 AM
> To: Maninder Singh; KY Srinivasan
> Cc: Haiyang Zhang; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org; pankaj.m@samsung.com
> Subject: Re: [PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation of
> correct pointer
> 
> Maninder Singh <maninder1.s@samsung.com> writes:
> 
> > cn_msg should be validated instead of msg after memory allocation.
> >
> 
> Thanks,
> 
> This was already fixed by Dan:
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-
> May/070193.html
> 
> my Reviewed-by:
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-
> June/070599.html
> 
> but I don't see it in K. Y. recent submission to Greg. K. Y., could you
> please pick it up?

Yes; will do.

K. Y
> 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> > ---
> >  drivers/hv/hv_utils_transport.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv_utils_transport.c
> b/drivers/hv/hv_utils_transport.c
> > index ea7ba5e..6a9d80a 100644
> > --- a/drivers/hv/hv_utils_transport.c
> > +++ b/drivers/hv/hv_utils_transport.c
> > @@ -186,7 +186,7 @@ int hvutil_transport_send(struct hvutil_transport
> *hvt, void *msg, int len)
> >  		return -EINVAL;
> >  	} else if (hvt->mode == HVUTIL_TRANSPORT_NETLINK) {
> >  		cn_msg = kzalloc(sizeof(*cn_msg) + len, GFP_ATOMIC);
> > -		if (!msg)
> > +		if (!cn_msg)
> >  			return -ENOMEM;
> >  		cn_msg->id.idx = hvt->cn_id.idx;
> >  		cn_msg->id.val = hvt->cn_id.val;
> 
> --
>   Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/