Date: Fri, 3 Jul 2015 22:42:13 +0200
From: Florian Westphal <fw@strlen.de>
To: Julien Grall <julien.grall@citrix.com>
Cc: stephen@networkplumber.org, davem@davemloft.net,
        bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        Bernhard Thaler <bernhard.thaler@wvnet.at>,
        Pablo Neira Ayuso <pablo@netfilter.org>, fw@strlen.de,
        ian.campbell@citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6
Message-ID: <20150703204213.GM16529@breakpoint.cc>
References: <1435946491-11148-1-git-send-email-julien.grall@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435946491-11148-1-git-send-email-julien.grall@citrix.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 886
Lines: 21

Julien Grall <julien.grall@citrix.com> wrote:
> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge:
> forward IPv6 fragmented packets" introduced a new function
> br_validate_ipv6 which take a reference on the inet6 device. Although,
> the reference is not released at the end.
> 
> This will result to the impossibility to destroy any netdevice using
> ipv6 and bridge.
> 
> Spotted while trying to destroy a Xen guest on the upstream Linux:
> "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Ugh :-/

I think it makes more sense to use __in6_dev_get() instead which doesn't
take a reference.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/