Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbbGDE5o (ORCPT ); Sat, 4 Jul 2015 00:57:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:59935 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbbGDE5e (ORCPT ); Sat, 4 Jul 2015 00:57:34 -0400 Date: Fri, 3 Jul 2015 21:57:35 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option Message-ID: <20150704045735.GB15817@jaegeuk-mac02.hsd1.ca.comcast.net> References: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> <1435603176-63219-11-git-send-email-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1752 Lines: 49 On Thu, Jul 02, 2015 at 08:35:34PM +0800, Chao Yu wrote: > > -----Original Message----- > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > > Sent: Tuesday, June 30, 2015 2:40 AM > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option > > > > This patch adds noextent_cache mount option. > > How about adding some descriptions in Documentation to help our user? > > The other thing is we'd better to show 'noextent_cache' option when user > lookups the mount options. > > How about adding codes as below? > if (test_opt(sbi, EXTENT_CACHE)) > seq_puts(seq, ",extent_cache"); > +else > + seq_puts(seq, ",noextent_cache"); > Agreed. Thanks, > > > > Signed-off-by: Jaegeuk Kim > > The other looks good to me, so please add: > > Reviewed-by: Chao Yu > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/