Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752701AbbGEJN5 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 5 Jul 2015 05:13:57 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34080 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750708AbbGEJNs convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 5 Jul 2015 05:13:48 -0400
Date: Sat, 4 Jul 2015 19:07:28 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Iago =?UTF-8?B?TMOzcGV6?= Galeiras <iago@endocode.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Djalal Harouni <djalal@endocode.com>,
        Alban Crequy <alban@endocode.com>
Subject: Re: config PROC_CHILDREN
Message-ID: <20150704190728.6a1b8a5a@endymion.delvare>
In-Reply-To: <55965195.6010602@endocode.com>
References: <20150703093918.75b98eb7@endymion.delvare>
	<55965195.6010602@endocode.com>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1629
Lines: 42

Hi Iago,

Please don't top-post.

On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote:
> Hi Jean,
> 
> The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
> having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.
> 
> Regarding its lack of help, documentation is in already in place[1] but perhaps
> that's not clear for the user because as you say the Kconfig help text is missing.
> 
> I suggest adding something like:
> 
>     Provides a fast way to retrieve first level children pids of a task. See
>     <file:Documentation/filesystems/proc.txt> for more information.
> 
> Do you think that's enough?

That's a start, the reference to Documentation/filesystems/proc.txt is
good but I think we can do better. You need to help the user make the
decision. Why should he/she say Y or N? The user should NOT have to look
at an external documentation file if the answer is N. I would suggest
the following:

Say Y if running any user-space software which takes benefit from this
interface. For example, rkt is such a piece of software.

That being said, I am curious... Is this interface so expensive that it
really deserves a separate option, instead of always enabling it? This
seems to be a fairly generic feature that a lot of scripts and tools
could benefit from (starting with pstree I suppose.)

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/