Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755980AbbGELuT (ORCPT ); Sun, 5 Jul 2015 07:50:19 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:59132 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbbGELuP (ORCPT ); Sun, 5 Jul 2015 07:50:15 -0400 Message-ID: <559919F5.8070107@kernel.org> Date: Sun, 05 Jul 2015 12:50:13 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Martin Kepplinger , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, mfuzzey@parkeon.com, roberta.dobrescu@gmail.com, christoph.muellner@theobroma-systems.com CC: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Martin Kepplinger Subject: Re: [PATCH 7/9] iio: mma8452: change iio event type to IIO_EV_TYPE_MAG References: <1436018110-3903-1-git-send-email-martink@posteo.de> <1436018110-3903-8-git-send-email-martink@posteo.de> In-Reply-To: <1436018110-3903-8-git-send-email-martink@posteo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2868 Lines: 73 On 04/07/15 14:55, Martin Kepplinger wrote: > IIO_EV_TYPE_THRESH in rising direction describes an event where the > threshold is crossed in rising direction, positive or negative values > being possible. This is not the case here. > > Since the threshold is no signed value and only the magnitude is compared, > IIO_EV_TYPE_MAG is what describes the behaviour of these devices, see the > sysfs-bus-iio ABI Documentation. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner This is a fix and so should have been the first patch in the series. It will want to go via a different tree (iio-fixes) and probably be marked for stable. I would however like Peter's ack on this as well before taking it. > --- > drivers/iio/accel/mma8452.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 7f6e3b4..e23ebd0 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -598,21 +598,21 @@ static void mma8452_transient_interrupt(struct iio_dev *indio_dev) > if (src & data->chip_info->ev_src_xe) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_X, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & data->chip_info->ev_src_ye) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Y, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & data->chip_info->ev_src_ze) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Z, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > } > @@ -689,7 +689,7 @@ static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, > > static const struct iio_event_spec mma8452_transient_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | > @@ -700,7 +700,7 @@ static const struct iio_event_spec mma8452_transient_event[] = { > > static const struct iio_event_spec mma8452_motion_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/