Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbbGENAG (ORCPT ); Sun, 5 Jul 2015 09:00:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbbGEM76 (ORCPT ); Sun, 5 Jul 2015 08:59:58 -0400 Date: Sun, 5 Jul 2015 14:59:54 +0200 From: "Michael S. Tsirkin" To: Thomas Huth Cc: virtualization@lists.linux-foundation.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] virtio: Fix typecast of pointer in vring_init() Message-ID: <20150705145917-mutt-send-email-mst@redhat.com> References: <1435821682-1809-1-git-send-email-thuth@redhat.com> <20150705124937-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150705124937-mutt-send-email-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2562 Lines: 71 On Sun, Jul 05, 2015 at 12:58:53PM +0200, Michael S. Tsirkin wrote: > On Thu, Jul 02, 2015 at 09:21:22AM +0200, Thomas Huth wrote: > > The virtio_ring.h header is used in userspace programs (ie. QEMU), > > too. Here we can not assume that sizeof(pointer) is the same as > > sizeof(long), e.g. when compiling for Windows, so the typecast in > > vring_init() should be done with (uintptr_t) instead of (unsigned long). > > > > Signed-off-by: Thomas Huth > > This seems to break some userspace too: > > INSTALL usr/include/linux/ (413 files) > CHECK usr/include/linux/ (413 files) > HOSTCC Documentation/accounting/getdelays > HOSTCC Documentation/connector/ucon > HOSTCC Documentation/mic/mpssd/mpssd.o > In file included from Documentation/mic/mpssd/mpssd.c:36:0: > ./usr/include/linux/virtio_ring.h: In function ‘vring_init’: > ./usr/include/linux/virtio_ring.h:146:24: error: ‘uintptr_t’ undeclared > (first use in this function) > vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + > sizeof(__virtio16) > ^ > ./usr/include/linux/virtio_ring.h:146:24: note: each undeclared > identifier is reported only once for each function it appears in > scripts/Makefile.host:108: recipe for target > 'Documentation/mic/mpssd/mpssd.o' failed > make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 > scripts/Makefile.build:403: recipe for target 'Documentation/mic/mpssd' > failed > make[2]: *** [Documentation/mic/mpssd] Error 2 > scripts/Makefile.build:403: recipe for target 'Documentation/mic' failed > make[1]: *** [Documentation/mic] Error 2 > > > E.g. fuse.h has this code: > #ifdef __KERNEL__ > #include > #else > #include > #endif > > Maybe we need something similar. The following seems to help. Does it help the windows build? --- include/uapi/linux/virtio_ring.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h index 8682551..c072959 100644 --- a/include/uapi/linux/virtio_ring.h +++ b/include/uapi/linux/virtio_ring.h @@ -31,6 +31,9 @@ * SUCH DAMAGE. * * Copyright Rusty Russell IBM Corporation 2007. */ +#ifndef __KERNEL__ +#include +#endif #include #include -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/