Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750897AbbGENAj (ORCPT ); Sun, 5 Jul 2015 09:00:39 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59486 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbbGENAd (ORCPT ); Sun, 5 Jul 2015 09:00:33 -0400 Message-ID: <55992A6D.6010506@roeck-us.net> Date: Sun, 05 Jul 2015 06:00:29 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jean Delvare CC: Constantine Shulyupin , open@suse.de, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] hwmon: (nct7802) Add pwm control References: <1436021854-13072-1-git-send-email-const@MakeLinux.com> <55982124.2070500@roeck-us.net> <20150705085727.23e25d08@endymion.delvare> In-Reply-To: <20150705085727.23e25d08@endymion.delvare> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 25 On 07/04/2015 11:57 PM, Jean Delvare wrote: > On Sat, 04 Jul 2015 11:08:36 -0700, Guenter Roeck wrote: >> Hi Constantine, >> >> On 07/04/2015 07:57 AM, Constantine Shulyupin wrote: >>> Added fan output control registers. >>> Modes of operation are PWM (default) and DC. >>> >> >> Another note: Since you mention DC vs. pwm mode, have you >> considered adding pwm[123]_mode attributes to report the >> selected mode ? > > If you do, please make sure these attributes are read-only. > They are. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/