Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbGEVGL (ORCPT ); Sun, 5 Jul 2015 17:06:11 -0400 Received: from imap.thunk.org ([74.207.234.97]:40708 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbbGEVGE (ORCPT ); Sun, 5 Jul 2015 17:06:04 -0400 Date: Sun, 5 Jul 2015 17:06:00 -0400 From: "Theodore Ts'o" To: Michal Hocko Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH] ext4: replace open coded nofail allocation Message-ID: <20150705210600.GD8628@thunk.org> Mail-Followup-To: Theodore Ts'o , Michal Hocko , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML References: <1435053037-1451-1-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435053037-1451-1-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 17 On Tue, Jun 23, 2015 at 11:50:37AM +0200, Michal Hocko wrote: > ext4_free_blocks is looping around the allocation request and mimics > __GFP_NOFAIL behavior without any allocation fallback strategy. Let's > remove the open coded loop and replace it with __GFP_NOFAIL. Without > the flag the allocator has no way to find out never-fail requirement > and cannot help in any way. > > Signed-off-by: Michal Hocko Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/