Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbbGFEBG (ORCPT ); Mon, 6 Jul 2015 00:01:06 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35763 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbbGFEAr convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 00:00:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150608181459.454c9067@amdc2363> References: <1433727349-23330-1-git-send-email-k.kozlowski@samsung.com> <20150608181459.454c9067@amdc2363> Date: Mon, 6 Jul 2015 13:00:46 +0900 X-Google-Sender-Auth: lvWAYmHQikuxNsj1P_q9PnacXh8 Message-ID: Subject: Re: [PATCH] thermal: exynos: Disable the regulator on probe failure From: Krzysztof Kozlowski To: Lukasz Majewski Cc: Krzysztof Kozlowski , Zhang Rui , Eduardo Valentin , Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2081 Lines: 58 2015-06-09 1:14 GMT+09:00 Lukasz Majewski : > Hi Krzysztof, > >> During probe the regulator (if present) was enabled but not disabled >> in case of failure. So an unsuccessful probe lead to enabling the >> regulator which was actually not needed because the device was not >> enabled. >> >> Additionally each deferred probe lead to increase of regulator enable >> count so it would not be effectively disabled during removal of the >> device. > > Thanks for catching this. > >> >> Signed-off-by: Krzysztof Kozlowski >> Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator >> defined at device tree") Cc: >> >> --- >> >> I am not entirely convinced that this should go to stable. Leaving a >> regulator enabled in case of probe failure (no exynos TMU device) or >> after deferred probe (regulator won't be disabled during device >> removal) is not a critical issue, just leaks power. >> --- >> drivers/thermal/samsung/exynos_tmu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/thermal/samsung/exynos_tmu.c >> b/drivers/thermal/samsung/exynos_tmu.c index >> 531f4b179871..13c3aceed19d 100644 --- >> a/drivers/thermal/samsung/exynos_tmu.c +++ >> b/drivers/thermal/samsung/exynos_tmu.c @@ -1392,6 +1392,8 @@ >> err_clk_sec: if (!IS_ERR(data->clk_sec)) >> clk_unprepare(data->clk_sec); >> err_sensor: >> + if (!IS_ERR_OR_NULL(data->regulator)) >> + regulator_disable(data->regulator); >> thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd); >> >> return ret; > > Acked-by: Lukasz Majewski > > I will test it and afterwards add to samsung-thermal tree. Hi Łukasz, I can't find this patch in v4.2-rc1 or your tree. What happened? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/