Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751041AbbGFGvK (ORCPT ); Mon, 6 Jul 2015 02:51:10 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:32854 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbbGFGvE (ORCPT ); Mon, 6 Jul 2015 02:51:04 -0400 Date: Mon, 6 Jul 2015 08:53:46 +0200 From: Daniel Vetter To: John Hunter Cc: SF Markus Elfring , Julia Lawall , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH] GPU-DRM: Delete an unnecessary check before drm_property_unreference_blob() Message-ID: <20150706065346.GA2156@phenom.ffwll.local> Mail-Followup-To: John Hunter , SF Markus Elfring , Julia Lawall , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <55998CD5.3080204@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 29 On Mon, Jul 06, 2015 at 10:01:52AM +0800, John Hunter wrote: > On Mon, Jul 6, 2015 at 4:00 AM, SF Markus Elfring < > elfring@users.sourceforge.net> wrote: > > > From: Markus Elfring > > Date: Sun, 5 Jul 2015 21:55:10 +0200 > > > > The drm_property_unreference_blob() function tests whether its argument > > is NULL and then returns immediately. > > Thus the test around the call is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > > > Reviewed-by: Zhao Junwang Applied to topic/drm-misc, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/