Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbbGFHdp (ORCPT ); Mon, 6 Jul 2015 03:33:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34361 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbbGFHdL (ORCPT ); Mon, 6 Jul 2015 03:33:11 -0400 Date: Mon, 6 Jul 2015 10:32:57 +0300 From: Dan Carpenter To: Arjun Krishna Babu Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function Message-ID: <20150706073257.GB28762@mwanda> References: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 21 On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Macros with flow control statements should be avoided > > Replace the macro with a function doing the exact same task as the > macro. > No. You haven't understood what DGNC_VERIFY_BOARD() does and have you even tried to compile this? Surely the compiler will complain that some paths don't have a return value? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/