Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 6 Feb 2003 17:46:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 6 Feb 2003 17:46:59 -0500 Received: from pizda.ninka.net ([216.101.162.242]:39897 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id ; Thu, 6 Feb 2003 17:46:58 -0500 Date: Thu, 06 Feb 2003 14:43:06 -0800 (PST) Message-Id: <20030206.144306.14966745.davem@redhat.com> To: christopher.leech@intel.com Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: skb_padto and small fragmented transmits From: "David S. Miller" In-Reply-To: <1044559328.4618.54.camel@localhost.localdomain> References: <1044559328.4618.54.camel@localhost.localdomain> X-FalunGong: Information control. X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 18 From: Chris Leech Date: 06 Feb 2003 11:22:08 -0800 OK, now I'm really getting confused. Every other example I can find in the networking code, and every scatter-gather capable driver, uses skb->len as the full length and skb->len - skb->data_len as the length of the first or linear portion. Indeed, Alan you need to fix the skb_padto stuff to use skb->len, ignore the skb->data_len as skb->len is the full length. Sorry for telling you to do the wrong thing Alan, my bad :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/