Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754604AbbGFKeD (ORCPT ); Mon, 6 Jul 2015 06:34:03 -0400 Received: from foss.arm.com ([217.140.101.70]:58426 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbbGFKeB (ORCPT ); Mon, 6 Jul 2015 06:34:01 -0400 Date: Mon, 6 Jul 2015 11:33:55 +0100 From: Catalin Marinas To: "Rafael J. Wysocki" Cc: Al Stone , linaro-kernel@lists.linaro.org, jason@lakedaemon.net, Al Stone , linaro-acpi@lists.linaro.org, patches@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, lenb@kernel.org Subject: Re: [PATCH v3 2/3] ACPI / ARM64: add BAD_MADT_GICC_ENTRY() macro Message-ID: <20150706103355.GC27723@e104818-lin.cambridge.arm.com> References: <1435880916-2153-1-git-send-email-al.stone@linaro.org> <20150703140601.GL25907@e104818-lin.cambridge.arm.com> <5596E7C8.7040809@redhat.com> <15297999.EvgjakjXbx@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15297999.EvgjakjXbx@vostro.rjw.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1795 Lines: 48 On Sat, Jul 04, 2015 at 01:54:15AM +0200, Rafael J. Wysocki wrote: > On Friday, July 03, 2015 01:51:36 PM Al Stone wrote: > > Perhaps the sanity checking for the MADT subtables needs to be revisited > > and a more general solution provided -- this is not the only MADT subtable > > with this problem and it may occur again. > > > > Even the versions above are not technically compliant with the spec. If > > we implement what the spec currently says, it might look something like > > this: > > > > #define ACPI_MADT_GICC_LENGTH ({ \ > > u8 length; \ > > switch (ACPI_FADT_SPEC_VERSION) { \ > > case ACPI_FADT_SPEC_VERSION_5_0: \ > > length = 40; \ > > break; \ > > case ACPI_FADT_SPEC_VERSION_5_1: \ > > length = 76; \ > > break; \ > > default: /* use 6.0 size */ \ > > length = 80; \ > > } \ > > length; \ > > }) > > > > So it's just messy and there will be a need for change. Let me think about > > making this a function instead of a macro; it may make sense to really fix > > BAD_MADT_ENTRY in general instead of just dealing with the GICC subtable, > > but it could also be overkill. > > So here's my suggestion. > > First, make ARM64 boot with 4.2+ in the simplest way possible. > > Second, set out to fix BAD_MADT_ENTRY() etc. Start with fixing ACPICA to > distinguish between the different formats depending on the spec version and > follow up from there. That's fine by me (as long as there is a plan to fix it properly, ideally in 4.3). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/