Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754626AbbGFKgi (ORCPT ); Mon, 6 Jul 2015 06:36:38 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:9288 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbbGFKge (ORCPT ); Mon, 6 Jul 2015 06:36:34 -0400 X-IronPort-AV: E=Sophos;i="5.15,414,1432598400"; d="scan'208";a="281342481" Message-ID: <559A5A0B.4040700@citrix.com> Date: Mon, 6 Jul 2015 11:35:55 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Florian Westphal CC: , , , , , , "Bernhard Thaler" , Pablo Neira Ayuso , , Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 References: <1435946491-11148-1-git-send-email-julien.grall@citrix.com> <20150703204213.GM16529@breakpoint.cc> In-Reply-To: <20150703204213.GM16529@breakpoint.cc> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 33 Hi, On 03/07/15 21:42, Florian Westphal wrote: > Julien Grall wrote: >> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: >> forward IPv6 fragmented packets" introduced a new function >> br_validate_ipv6 which take a reference on the inet6 device. Although, >> the reference is not released at the end. >> >> This will result to the impossibility to destroy any netdevice using >> ipv6 and bridge. >> >> Spotted while trying to destroy a Xen guest on the upstream Linux: >> "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1" > > Ugh :-/ > > I think it makes more sense to use __in6_dev_get() instead which doesn't > take a reference. __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on this code is very limited. Are we sure that one this lock is hold? At first glance, I wasn't able to find one. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/