Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbbGFKsW (ORCPT ); Mon, 6 Jul 2015 06:48:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46873 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbbGFKsT (ORCPT ); Mon, 6 Jul 2015 06:48:19 -0400 Date: Mon, 6 Jul 2015 16:18:15 +0530 From: Pratyush Anand To: Will Deacon Cc: "linux-arm-kernel@lists.infradead.org" , "linux@arm.linux.org.uk" , Catalin Marinas , "linux-kernel@vger.kernel.org" , "wcohen@redhat.com" , "dave.long@linaro.org" , "steve.capper@linaro.org" , "masami.hiramatsu.pt@hitachi.com" Subject: Re: [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols Message-ID: <20150706104815.GA17305@dhcppc13.redhat.com> References: <9994841a0b0a8194a6dcc1b6af148ba358488c62.1436158027.git.panand@redhat.com> <20150706090323.GB30342@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150706090323.GB30342@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 44 On 06/07/2015:10:03:24 AM, Will Deacon wrote: > On Mon, Jul 06, 2015 at 06:03:21AM +0100, Pratyush Anand wrote: > > Add all function symbols which are called from do_debug_exception under > > NOKPROBE_SYMBOL, as they can not kprobed. > > It's a shame this has to be so manual, but I suppose it's done on a > best-effort basis to catch broken probe placement. > > If we miss a function and somebody probes it, do we just get stuck in a > recursive exception, or could we print something suggesting that a symbol > be annotated as NOKPROBE? In some cases we land into a recursive reenter_kprobe: echo "p kfree" > /sys/kernel/debug/tracing/kprobe_events echo "p single_step_handler" >> /sys/kernel/debug/tracing/kprobe_events echo 1 > /sys/kernel/debug/tracing/events/enable [ 116.904194] BUG: failure at .../arch/arm64/kernel/kprobes.c:288/reenter_kprobe()! In some other echo "p kfree" > /sys/kernel/debug/tracing/kprobe_events echo "p el0_sync" >> /sys/kernel/debug/tracing/kprobe_events echo 1 > /sys/kernel/debug/tracing/events/enable Infinite loop of: [ 142.731336] Unexpected kernel single-step exception at EL1 In 1st case currently only address is printed. pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr); So, while in 1st case we may also print name of symbol, we can not do much in second case. Now, I am running some test with all the symbols in /proc/kallsyms and I noticed that there might be few more symbols which may not allow kprobing. So, may be I will resend this series with updates. ~Pratyush -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/