Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbbGFLUH (ORCPT ); Mon, 6 Jul 2015 07:20:07 -0400 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:58530 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754169AbbGFLUD (ORCPT ); Mon, 6 Jul 2015 07:20:03 -0400 Date: Mon, 6 Jul 2015 13:19:53 +0200 From: Florian Westphal To: Julien Grall Cc: Florian Westphal , stephen@networkplumber.org, davem@davemloft.net, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Bernhard Thaler , Pablo Neira Ayuso , ian.campbell@citrix.com, wei.liu2@citrix.com Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 Message-ID: <20150706111952.GC16864@breakpoint.cc> References: <1435946491-11148-1-git-send-email-julien.grall@citrix.com> <20150703204213.GM16529@breakpoint.cc> <559A5A0B.4040700@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559A5A0B.4040700@citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 17 Julien Grall wrote: > On 03/07/15 21:42, Florian Westphal wrote: > > I think it makes more sense to use __in6_dev_get() instead which doesn't > > take a reference. > > __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on > this code is very limited. Are we sure that one this lock is hold? At > first glance, I wasn't able to find one. All netfilter hooks are rcu_read_locked via nf_hook_slow(). BTW, netfilter patches should be sent to netfilter-devel@vger.kernel.org. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/