Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754415AbbGFLdg (ORCPT ); Mon, 6 Jul 2015 07:33:36 -0400 Received: from smtp.citrix.com ([66.165.176.89]:11350 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbbGFLde (ORCPT ); Mon, 6 Jul 2015 07:33:34 -0400 X-IronPort-AV: E=Sophos;i="5.15,414,1432598400"; d="scan'208";a="278314706" Message-ID: <559A675B.80408@citrix.com> Date: Mon, 6 Jul 2015 12:32:43 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Florian Westphal CC: , , , , , , Bernhard Thaler , , , Pablo Neira Ayuso Subject: Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 References: <1435946491-11148-1-git-send-email-julien.grall@citrix.com> <20150703204213.GM16529@breakpoint.cc> <559A5A0B.4040700@citrix.com> <20150706111952.GC16864@breakpoint.cc> In-Reply-To: <20150706111952.GC16864@breakpoint.cc> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 28 On 06/07/15 12:19, Florian Westphal wrote: > Julien Grall wrote: >> On 03/07/15 21:42, Florian Westphal wrote: >>> I think it makes more sense to use __in6_dev_get() instead which doesn't >>> take a reference. >> >> __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on >> this code is very limited. Are we sure that one this lock is hold? At >> first glance, I wasn't able to find one. > > All netfilter hooks are rcu_read_locked via nf_hook_slow(). Ok. I will resend the patch with __in6_dev_get. > BTW, netfilter patches should be sent to netfilter-devel@vger.kernel.org. I used scripts/get_maintainer.pl which doesn't provide this mailing list for net/bridge/br_netfilter*.c Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/