Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbbGFMPd (ORCPT ); Mon, 6 Jul 2015 08:15:33 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33018 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbGFMPc (ORCPT ); Mon, 6 Jul 2015 08:15:32 -0400 Date: Mon, 6 Jul 2015 17:45:24 +0530 From: Ravi Teja Darbha To: Arjun Krishna Babu Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function Message-ID: <20150706121524.GB2226@gmail.com> References: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1968 Lines: 64 What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with its definition. Regards, Ravi Teja On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Macros with flow control statements should be avoided > > Replace the macro with a function doing the exact same task as the > macro. > > Signed-off-by: Arjun Krishna Babu > --- > drivers/staging/dgnc/dgnc_sysfs.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 44db870..8ab0922 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -92,19 +92,17 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) > } > > > -#define DGNC_VERIFY_BOARD(p, bd) \ > - do { \ > - if (!p) \ > - return 0; \ > - \ > - bd = dev_get_drvdata(p); \ > - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ > - return 0; \ > - if (bd->state != BOARD_READY) \ > - return 0; \ > - } while (0) > - > +static int DGNC_VERIFY_BOARD(struct device *p, struct dgnc_board *bd) > +{ > + if (!p) > + return 0; > > + bd = dev_get_drvdata(p); > + if (!bd || bd->magic != DGNC_BOARD_MAGIC) > + return 0; > + if (bd->state != BOARD_READY) > + return 0; > +} > > static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, > char *buf) > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/