Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628AbbGFMcp (ORCPT ); Mon, 6 Jul 2015 08:32:45 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36206 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755603AbbGFMcl (ORCPT ); Mon, 6 Jul 2015 08:32:41 -0400 Date: Mon, 6 Jul 2015 17:57:06 +0530 From: Sudip Mukherjee To: Ravi Teja Darbha Cc: Arjun Krishna Babu , devel@driverdev.osuosl.org, lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function Message-ID: <20150706122705.GA3285@sudip-PC> References: <1436120188-15368-1-git-send-email-arjunkrishnababu96@gmail.com> <20150706121524.GB2226@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150706121524.GB2226@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 524 Lines: 12 On Mon, Jul 06, 2015 at 05:45:24PM +0530, Ravi Teja Darbha wrote: > What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with its definition. And repeating the same code 12 times?? That is why the macro is there, to avoid the duplication of code. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/