Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958AbbGFMuw (ORCPT ); Mon, 6 Jul 2015 08:50:52 -0400 Received: from mx0b-00176a03.pphosted.com ([67.231.157.48]:26672 "EHLO mx0b-00176a03.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbbGFMuu (ORCPT ); Mon, 6 Jul 2015 08:50:50 -0400 Message-ID: <559A7533.8000408@ge.com> Date: Mon, 6 Jul 2015 13:31:47 +0100 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dmitry Kalinkin , , CC: Manohar Vanga , Greg Kroah-Hartman , Igor Alekseev Subject: Re: [PATCH 0/3] VME bus error handling overhaul References: <1435846266-26958-1-git-send-email-dmitry.kalinkin@gmail.com> In-Reply-To: <1435846266-26958-1-git-send-email-dmitry.kalinkin@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [3.159.19.192] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507060201 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2087 Lines: 47 Hi Dmitry, These are looking good to me. You mention error handling in relation to vme_master_mmap, am I right in thinking patch 3 avoids errors being recorded when triggered by an mmap access (so as not to appear as a spurious error on a later access)? I think it would be worth at least logging errors to the kernel log should they be generated and not be handled by a error handler, so someone using mmap gets at least some form of notification that their accesses are resulting on bus errors. What do you think? Martyn On 02/07/15 15:11, Dmitry Kalinkin wrote: > This moves tsi148 error handling into VME subsystem so it can be shared with > the other bridge driver. Then there is a change to close a fixme on separating > errors by address space. And finally a fix for memory leak problem that was > introduced with support of mmap's. > > The next logical step in this direction would be to add error handling support > to ca91cx42 and make it unconditional for tsi148. It also makes much sense to > add synchronization to error-related list operations (spinlocks, rcu). > > Dmitry Kalinkin (3): > vme: move tsi148 error handling into VME subsystem > vme: include address space in error filtering > vme: change bus error handling scheme > > drivers/vme/bridges/vme_ca91cx42.c | 3 +- > drivers/vme/bridges/vme_tsi148.c | 170 ++++++++++--------------------------- > drivers/vme/vme.c | 83 ++++++++++++++++++ > drivers/vme/vme_bridge.h | 21 +++-- > 4 files changed, 147 insertions(+), 130 deletions(-) > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/