Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbbGFNDA (ORCPT ); Mon, 6 Jul 2015 09:03:00 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:35585 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbbGFNC6 (ORCPT ); Mon, 6 Jul 2015 09:02:58 -0400 MIME-Version: 1.0 In-Reply-To: <1436165530-41963-1-git-send-email-koro.chen@mediatek.com> References: <1436165530-41963-1-git-send-email-koro.chen@mediatek.com> From: Daniel Kurtz Date: Mon, 6 Jul 2015 21:02:38 +0800 X-Google-Sender-Auth: m4DH2XYgxThB82dKw-8lo5rRMWM Message-ID: Subject: Re: [PATCH] arm64: dts: mt8173: Add afe device node To: Koro Chen Cc: Matthias Brugger , srv_heupstream , linux-mediatek@lists.infradead.org, Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , alsa-devel@alsa-project.org, "open list:OPEN FIRMWARE AND..." , Nicolas Boichat Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3361 Lines: 78 On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen wrote: > This adds afe (audio front end) device node to the MT8173 dtsi file. > > This patch is based on Matthias's tree: > https://github.com/mbgg/linux-mediatek > branch: v4.2-next/arm64 > > Signed-off-by: Koro Chen > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 0696f8f..f8afab4 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include "mt8173-pinfunc.h" > > @@ -393,6 +394,37 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + afe: mt8173-afe-pcm@11220000 { I believe this should be something generic, like: afe: audio-controller@11220000 Thanks! -Dan > + compatible = "mediatek,mt8173-afe-pcm"; > + reg = <0 0x11220000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>; > + clocks = <&infracfg CLK_INFRA_AUDIO>, > + <&topckgen CLK_TOP_AUDIO_SEL>, > + <&topckgen CLK_TOP_AUD_INTBUS_SEL>, > + <&topckgen CLK_TOP_APLL1_DIV0>, > + <&topckgen CLK_TOP_APLL2_DIV0>, > + <&topckgen CLK_TOP_I2S0_M_SEL>, > + <&topckgen CLK_TOP_I2S1_M_SEL>, > + <&topckgen CLK_TOP_I2S2_M_SEL>, > + <&topckgen CLK_TOP_I2S3_M_SEL>, > + <&topckgen CLK_TOP_I2S3_B_SEL>; > + clock-names = "infra_sys_audio_clk", > + "top_pdn_audio", > + "top_pdn_aud_intbus", > + "bck0", > + "bck1", > + "i2s0_m", > + "i2s1_m", > + "i2s2_m", > + "i2s3_m", > + "i2s3_b"; > + assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>, > + <&topckgen CLK_TOP_AUD_2_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_APLL1>, > + <&topckgen CLK_TOP_APLL2>; > + }; > }; > }; > > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/