Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755464AbbGFNWx (ORCPT ); Mon, 6 Jul 2015 09:22:53 -0400 Received: from mx0b-00176a03.pphosted.com ([67.231.157.48]:17418 "EHLO mx0b-00176a03.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407AbbGFNWu (ORCPT ); Mon, 6 Jul 2015 09:22:50 -0400 Message-ID: <559A8117.4060701@ge.com> Date: Mon, 6 Jul 2015 14:22:31 +0100 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , Dmitry Kalinkin CC: , , "Manohar Vanga" , Igor Alekseev Subject: Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality References: <1432814833-5320-1-git-send-email-dmitry.kalinkin@gmail.com> <1432814833-5320-9-git-send-email-dmitry.kalinkin@gmail.com> <20150613002807.GA17459@kroah.com> In-Reply-To: <20150613002807.GA17459@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [3.159.212.193] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=18 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507060213 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 33 On 13/06/15 01:28, Greg Kroah-Hartman wrote: > On Thu, May 28, 2015 at 03:07:05PM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user space. >> >> Signed-off-by: Dmitry Kalinkin >> Cc: Igor Alekseev >> --- >> drivers/staging/vme/devices/vme_user.c | 201 ++++++++++++++++++++++++++++++++- >> drivers/staging/vme/devices/vme_user.h | 11 ++ >> 2 files changed, 209 insertions(+), 3 deletions(-) > > I want to get Martyn's feedback on this, as it's adding a new feature to > the subsystem that he's going to have to maintain. > Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing list. I'm happy with the addition of DMA, just not sure whether it's worth adding an extra device file just to handle DMA. Could the user space application not just use the control device? -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/