Date: Mon, 6 Jul 2015 15:33:08 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Cohen <david.a.cohen@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alan Cox <alan@linux.intel.com>,
        "Stuart R. Anderson" <stuart.r.anderson@intel.com>,
        Joe Perches <joe@perches.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH] x86: Allow early_printk to use console style param
 like 115200n8
Message-ID: <20150706133308.GA7011@gmail.com>
References: <20150703181643.4fd4053d@grimm.local.home>
 <20150704110359.GA18107@gmail.com>
 <20150704092000.322dc4e6@grimm.local.home>
 <559A82D6.5040007@hurleysoftware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <559A82D6.5040007@hurleysoftware.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1509
Lines: 46


* Peter Hurley <peter@hurleysoftware.com> wrote:

> On 07/04/2015 09:20 AM, Steven Rostedt wrote:
> > On Sat, 4 Jul 2015 13:03:59 +0200
> > Ingo Molnar <mingo@kernel.org> wrote:
> > 
> > 
> >>> +		/*
> >>> +		 * In case the input is like console with text after the baud
> >>> +		 * rate. e.g. 115200n8. kstrtoul() will error on such input.
> >>> +		 */
> >>> +		for (p = s; *p && isdigit(*p); p++)
> >>> +			;
> >>> +		*p = 0;
> >>> +
> >>>  		if (kstrtoul(s, 0, &baud) < 0 || baud == 0)
> >>>  			baud = DEFAULT_BAUD;
> >>
> >>
> > 
> > This was actually one of those cases where I wanted to show that keeping the 
> > old function around is better than the alternative ;-)
> > 
> > If people say we need to phase out simple_strtoull(), then I wanted to show 
> > what kinds of hacks we will have if that happens.
> > 
> > I was hoping that someone would point out that simple_strtoull() is a better 
> > solution. :)
> 
> And made worse by the fact that checkpatch flags simple_strtoul* as obsolete, so 
> people keep submitting junk like above [1] in an effort to escape the checkpatch 
> warning.
> 
> Which I pointed out to Joe back in Feb. (https://lkml.org/lkml/2015/2/25/217)

So this kind of checkpatch-driven crap really needs to stop.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/