Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756453AbbGFNyH (ORCPT ); Mon, 6 Jul 2015 09:54:07 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:43359 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754887AbbGFNyE (ORCPT ); Mon, 6 Jul 2015 09:54:04 -0400 Date: Mon, 6 Jul 2015 21:53:54 +0800 From: Herbert Xu To: Phil Sutter Cc: Thomas Graf , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, daniel@iogearbox.net, geert@linux-m68k.org, mroos@linux.ee Subject: Re: [PATCH v2] rhashtable: fix for resize events during table walk Message-ID: <20150706135353.GA22998@gondor.apana.org.au> References: <1436190680-21887-1-git-send-email-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436190680-21887-1-git-send-email-phil@nwl.cc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 26 On Mon, Jul 06, 2015 at 03:51:20PM +0200, Phil Sutter wrote: > If rhashtable_walk_next detects a resize operation in progress, it jumps > to the new table and continues walking that one. But it misses to drop > the reference to it's current item, leading it to continue traversing > the new table's bucket in which the current item is sorted into, and > after reaching that bucket's end continues traversing the new table's > second bucket instead of the first one, thereby potentially missing > items. > > This fixes the rhashtable runtime test for me. Bug probably introduced > by Herbert Xu's patch eddee5ba ("rhashtable: Fix walker behaviour during > rehash") although not explicitly tested. > > Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash") > Signed-off-by: Phil Sutter Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/